Removed semaphore.wait() and introduced a timer pause boolean. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case there flushSync is no longer synonymous because it doesn’t wait for it to complete, maybe we could test just calling “flush” instead of “flushAsync” when the app goes to background or is closed? |
|
I think we shouldn't block the app until the http call completes (unpredictable response time). Maybe the sdk consumer can decide whether to call flush on applicationDidEnterBackground if needed (https://developers.google.com/analytics/devguides/collection/ios/v3/dispatch#override-applicationDidEnterBackground) |
|
We will document a solution for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for app hang caused by
flushSync()in aptabaseClient.swift.Removed semaphore.wait() and added a variable to pause the timer execution if flush isn't done executing.
closes #18