Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip loading reflists when listing published repos #1227

Closed
wants to merge 1 commit into from

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Oct 24, 2023

Description of the Change

Loading the reflists to list publish information takes a significant amount of time, even though the resulting info doesn't actually use any of the reflists.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

The output doesn't actually depend on the reflists, and loading them for
every published repo starts to take substantial time and memory.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.85%. Comparing base (f155ed3) to head (89dcf7b).
Report is 46 commits behind head on master.

Files Patch % Lines
deb/publish.go 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   65.96%   74.85%   +8.89%     
==========================================
  Files         143      143              
  Lines       16188    16197       +9     
==========================================
+ Hits        10679    12125    +1446     
+ Misses       4756     3136    -1620     
- Partials      753      936     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants