Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip loading reflists when listing published repos #1274

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Apr 17, 2024

Replaces #1227

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Loading the reflists to list publish information takes a significant amount of time, even though the resulting info doesn't actually use any of the reflists.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.79%. Comparing base (27013c0) to head (1325f7b).

Files Patch % Lines
deb/publish.go 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   74.78%   74.79%           
=======================================
  Files         144      144           
  Lines       16246    16256   +10     
=======================================
+ Hits        12150    12158    +8     
- Misses       3154     3156    +2     
  Partials      942      942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx self-assigned this Apr 18, 2024
@neolynx neolynx changed the title Feature/publish perf publish list reflists Skip loading reflists when listing published repos Apr 20, 2024
@neolynx neolynx added needs review Ready for review & merge needs rebase The PR needs to be rebased on master labels Apr 20, 2024
@neolynx neolynx force-pushed the feature/publish-perf-publish-list-reflists branch from 9cc2743 to 8477cfa Compare April 21, 2024 09:25
@neolynx neolynx removed the needs rebase The PR needs to be rebased on master label Apr 21, 2024
@neolynx neolynx force-pushed the feature/publish-perf-publish-list-reflists branch from 8477cfa to 16d8a32 Compare April 21, 2024 09:32
@neolynx neolynx removed the needs review Ready for review & merge label Apr 24, 2024
The output doesn't actually depend on the reflists, and loading them for
every published repo starts to take substantial time and memory.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
@neolynx neolynx force-pushed the feature/publish-perf-publish-list-reflists branch from 16d8a32 to 1325f7b Compare April 24, 2024 14:51
@neolynx neolynx merged commit 8d09c20 into master Apr 24, 2024
8 of 9 checks passed
@neolynx neolynx deleted the feature/publish-perf-publish-list-reflists branch April 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants