Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress details for publish api #675

Closed
wants to merge 9 commits into from

Conversation

sliverc
Copy link
Contributor

@sliverc sliverc commented Nov 20, 2017

This introduces progress detail for publish api based on non locking and async api in PR #459. Hence PR #459 needs to be merged first before merging this PR.

Relevant changes in this PR are commits smira@005ce6f and smira@27aa816

Example:
GET /api/tasks/TASK_ID/detail (replace TASK_ID with publish task)

Result would look like this:

{
  'RemainingNumberOfPackages': 102,
  'TotalNumberOfPackages': 546
}

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@sliverc sliverc force-pushed the publish_single_progress branch 3 times, most recently from ce344ba to e1e59dd Compare December 1, 2017 08:25
@hsitter hsitter added the 1.5.0 label Apr 30, 2018
@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #675 into master will increase coverage by 0.21%.
The diff coverage is 61.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   60.64%   60.86%   +0.21%     
==========================================
  Files          50       54       +4     
  Lines        6276     6436     +160     
==========================================
+ Hits         3806     3917     +111     
- Misses       2033     2093      +60     
+ Partials      437      426      -11
Impacted Files Coverage Δ
deb/changes.go 59.91% <ø> (+0.17%) ⬆️
deb/index_files.go 42.67% <0%> (ø) ⬆️
deb/list.go 79.55% <0%> (ø) ⬆️
files/package_pool.go 67.17% <0%> (ø) ⬆️
context/context.go 11.72% <0%> (-0.4%) ⬇️
deb/package_collection.go 54.83% <100%> (+3.32%) ⬆️
deb/local.go 92.78% <100%> (+5.65%) ⬆️
task/task.go 100% <100%> (ø)
database/leveldb.go 79.24% <100%> (-2.12%) ⬇️
http/temp.go 77.77% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a704de...21e1571. Read the comment docs.

@lbolla lbolla closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants