-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress details for publish api #675
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliverc
force-pushed
the
publish_single_progress
branch
3 times, most recently
from
December 1, 2017 08:25
ce344ba
to
e1e59dd
Compare
sliverc
force-pushed
the
publish_single_progress
branch
from
December 18, 2017 10:11
e1e59dd
to
85c156b
Compare
sliverc
force-pushed
the
publish_single_progress
branch
from
May 17, 2018 13:45
85c156b
to
2a6a17e
Compare
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 60.64% 60.86% +0.21%
==========================================
Files 50 54 +4
Lines 6276 6436 +160
==========================================
+ Hits 3806 3917 +111
- Misses 2033 2093 +60
+ Partials 437 426 -11
Continue to review full report at Codecov.
|
sliverc
force-pushed
the
publish_single_progress
branch
from
May 22, 2018 07:51
2a6a17e
to
d77862e
Compare
sliverc
force-pushed
the
publish_single_progress
branch
from
May 31, 2018 12:19
d77862e
to
f69f1da
Compare
sliverc
force-pushed
the
publish_single_progress
branch
from
June 20, 2018 13:00
f69f1da
to
a0fcd80
Compare
this is needed so concurrent reads and writes are possible.
This way db usage is safe.
Progress is not safe so for api its always nil and code needs to take care of this
sliverc
force-pushed
the
publish_single_progress
branch
from
July 6, 2018 13:17
a0fcd80
to
21e1571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces progress detail for publish api based on non locking and async api in PR #459. Hence PR #459 needs to be merged first before merging this PR.
Relevant changes in this PR are commits smira@005ce6f and smira@27aa816
Example:
GET /api/tasks/TASK_ID/detail (replace TASK_ID with publish task)
Result would look like this:
Checklist
AUTHORS