Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwk consensus e2e #11528

Closed
wants to merge 54 commits into from
Closed

jwk consensus e2e #11528

wants to merge 54 commits into from

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Jan 1, 2024

Description

The state and transition rules to execute per-issuer JWK consensus protocols.

Doing this in a per-issuer manner is preferred, otherwise an intermittently equivocating issuer can block the quorum-certified update of other issuers' keys.

If at any time there are multiple quorum-certified JWK updates (for multiple issuers), they can be merged into a single validator transaction.

Copy link

trunk-io bot commented Jan 1, 2024

⏱️ 35h 9m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 4h 39m 🟩🟩🟩🟥🟥 (+11 more)
rust-unit-tests 4h 23m 🟥🟥 (+10 more)
execution-performance / single-node-performance 4h 3m 🟩🟩🟩🟩🟩 (+7 more)
rust-smoke-tests 3h 36m 🟥🟥 (+7 more)
forge-framework-upgrade-test / forge 3h 35m 🟥🟥🟥🟥 (+1 more)
rust-smoke-coverage 2h 56m 🟩
rust-images / rust-all 1h 42m 🟩🟥 (+7 more)
forge-compat-test / forge 1h 34m 🟩🟩🟩🟩🟩 (+2 more)
rust-lints 1h 27m 🟥🟩🟥 (+10 more)
forge-e2e-test / forge 1h 23m 🟥🟩🟥🟩🟩 (+1 more)
run-tests-main-branch 1h 4m 🟩🟩🟩🟩🟩 (+10 more)
check 1h 🟩🟩🟩🟩 (+11 more)
cli-e2e-tests / run-cli-tests 51m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 38m 🟩🟩🟩🟩 (+10 more)
rust-move-unit-coverage 34m 🟩
check-dynamic-deps 34m 🟩🟩🟩🟩🟩 (+11 more)
rust-unit-coverage 28m
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 10m 🟩🟩🟩🟩🟩 (+1 more)
semgrep/ci 6m 🟩🟩🟩🟩🟩 (+11 more)
node-api-compatibility-tests / node-api-compatibility-tests 5m 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 3m
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+10 more)
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+10 more)
execution-performance / file_change_determinator 2m 🟩🟩🟩🟩🟩 (+7 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+7 more)
execution-performance / parallel-execution-performance 2m 🟩🟩🟩🟩🟩 (+7 more)
execution-performance / sequential-execution-performance 1m 🟩🟩🟩🟩🟩 (+7 more)
permission-check 55s 🟩🟩🟩🟩🟩 (+11 more)
permission-check 46s 🟩🟩🟩🟩🟩 (+7 more)
permission-check 43s 🟩🟩🟩🟩🟩 (+11 more)
permission-check 43s 🟩🟩🟩🟩🟩 (+11 more)
permission-check 42s 🟩🟩🟩🟩🟩 (+11 more)
determine-docker-build-metadata 37s 🟩🟩🟩🟩🟩 (+7 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@zjma zjma changed the title jwk consensus state machine per-issuer jwk consensus states Jan 1, 2024
@zjma zjma marked this pull request as ready for review January 1, 2024 01:13
@zjma zjma requested a review from JoshLind as a code owner January 1, 2024 01:13
@zjma zjma requested review from zekun000, danielxiangzl and grao1991 and removed request for JoshLind January 1, 2024 01:13
@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jan 1, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Forge suite realistic_env_max_load failure on 1dd8d7947bdac646c43527414b2238ea1713a724

Forge test runner terminated:
Trailing Log Lines:
  29: std::panicking::try
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:516:19
  30: std::panic::catch_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panic.rs:142:14
  31: std::rt::lang_start_internal
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:148:20
  32: std::rt::lang_start
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/rt.rs:166:17
  33: __libc_start_main
  34: _start
Debugging output:
NAME                                   READY   STATUS             RESTARTS      AGE
aptos-node-0-fullnode-eforge14-0       0/1     CrashLoopBackOff   2 (23s ago)   2m33s
aptos-node-0-validator-0               1/1     Running            0             2m33s
aptos-node-1-fullnode-eforge14-0       0/1     CrashLoopBackOff   2 (12s ago)   2m33s
aptos-node-1-validator-0               1/1     Running            0             2m33s
aptos-node-2-fullnode-eforge14-0       0/1     CrashLoopBackOff   2 (21s ago)   2m33s
aptos-node-2-validator-0               1/1     Running            0             2m33s
aptos-node-3-fullnode-eforge14-0       0/1     Error              2 (19s ago)   2m32s
aptos-node-3-validator-0               1/1     Running            0             2m33s
aptos-node-4-fullnode-eforge14-0       0/1     CrashLoopBackOff   2 (24s ago)   2m33s
aptos-node-4-validator-0               1/1     Running            0             2m32s
aptos-node-5-validator-0               1/1     Running            0             2m33s
aptos-node-6-validator-0               1/1     Running            0             2m33s
genesis-aptos-genesis-eforge14-m4ndf   0/1     Completed          0             3m3s

Copy link
Contributor

github-actions bot commented Feb 1, 2024

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 1dd8d7947bdac646c43527414b2238ea1713a724

Compatibility test results for aptos-node-v1.8.3 ==> 1dd8d7947bdac646c43527414b2238ea1713a724 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4829 txn/s, latency: 6724 ms, (p50: 6500 ms, p90: 10200 ms, p99: 14500 ms), latency samples: 183520
2. Upgrading first Validator to new version: 1dd8d7947bdac646c43527414b2238ea1713a724
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1774 txn/s, latency: 15860 ms, (p50: 19300 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 92260
3. Upgrading rest of first batch to new version: 1dd8d7947bdac646c43527414b2238ea1713a724
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1416 txn/s, latency: 19736 ms, (p50: 20500 ms, p90: 27600 ms, p99: 28700 ms), latency samples: 73680
4. upgrading second batch to new version: 1dd8d7947bdac646c43527414b2238ea1713a724
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2622 txn/s, latency: 12267 ms, (p50: 12300 ms, p90: 18000 ms, p99: 20300 ms), latency samples: 110140
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 1dd8d7947bdac646c43527414b2238ea1713a724 passed
Test Ok

@zjma zjma closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR JWK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants