Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aptos Framework] [Account] wrapped error code #3893

Merged
merged 2 commits into from
Sep 7, 2022
Merged

[Aptos Framework] [Account] wrapped error code #3893

merged 2 commits into from
Sep 7, 2022

Conversation

0xchloe
Copy link
Contributor

@0xchloe 0xchloe commented Sep 6, 2022 •
edited
Loading

Description

changed if.. else.. to if.. else if.. abort.. and wrapped some error code

Test Plan

existing unit tests

This change is Reviewable

alinush
alinush approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@alinush alinush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there's a few missing wraps on lines 313, 322 and 335.

@0xchloe
Copy link
Contributor Author

0xchloe commented Sep 6, 2022

Looks good but there's a few missing wraps on lines 313, 322 and 335.

oh yea those are part of this other pr #3293

@0xchloe 0xchloe enabled auto-merge (squash) September 7, 2022 05:00
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Forge is running with 76e4eb1b718be24dd42ff4d82c0272cb78c89476

✅ Forge test success on 76e4eb1b718be24dd42ff4d82c0272cb78c89476

performance benchmark with full nodes : 7091 TPS, 4204 ms latency, 6000 ms p99 latency,no expired txns
Test Ok

@0xchloe 0xchloe merged commit fa49b5d into main Sep 7, 2022
@0xchloe 0xchloe deleted the error_code branch September 7, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areshand areshand areshand approved these changes

@alinush alinush alinush approved these changes

@movekevin movekevin Awaiting requested review from movekevin

@davidiw davidiw Awaiting requested review from davidiw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xchloe @areshand @alinush