Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audit] timestamp.move #4619

Merged
merged 1 commit into from Sep 29, 2022
Merged

[audit] timestamp.move #4619

merged 1 commit into from Sep 29, 2022

Conversation

lightmark
Copy link
Contributor

@lightmark lightmark commented Sep 28, 2022

Description

nits

Test Plan


This change is Reviewable

};
global_timer.microseconds = timestamp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary but is technically a no-op if (proposer == @vm_reserved) so more of a cleanup? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save gas? lol.

Copy link
Contributor

@movekevin movekevin Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not worry about gas for this one line. It's trivial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am kidding tho

@lightmark lightmark enabled auto-merge (squash) September 29, 2022 20:14
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on 843b204dce971d98449b82624f4f684c7a18b991 ==> 94c94b04d81acb6840459a72a9a4dee022dcc3f7

Compatibility test results for 843b204dce971d98449b82624f4f684c7a18b991 ==> 94c94b04d81acb6840459a72a9a4dee022dcc3f7 (PR)
1. Check liveness of validators at old version: 843b204dce971d98449b82624f4f684c7a18b991
compatibility::simple-validator-upgrade::liveness-check : 7818 TPS, 4599 ms latency, 6700 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 94c94b04d81acb6840459a72a9a4dee022dcc3f7
compatibility::simple-validator-upgrade::single-validator-upgrade : 5349 TPS, 7173 ms latency, 9300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 94c94b04d81acb6840459a72a9a4dee022dcc3f7
compatibility::simple-validator-upgrade::half-validator-upgrade : 4966 TPS, 8160 ms latency, 13800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 94c94b04d81acb6840459a72a9a4dee022dcc3f7
compatibility::simple-validator-upgrade::rest-validator-upgrade : 8096 TPS, 4474 ms latency, 8100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 843b204dce971d98449b82624f4f684c7a18b991 ==> 94c94b04d81acb6840459a72a9a4dee022dcc3f7 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 94c94b04d81acb6840459a72a9a4dee022dcc3f7

performance benchmark with full nodes : 7721 TPS, 5144 ms latency, 8100 ms p99 latency,(!) expired 160 out of 3297400 txns
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants