[Stake] Validate lockup

[movekevin]

Description

Ensure that the new lockup period (set as now + fixed recurring lockup) > old lockup. There could be an edge case when the on chain governance reduces recurring lockup, which allows increase_lockup to overrides the old lockup with a new shorter one.

Test Plan

Added unit test

---

This change is 

[davidiw]

pretty boring, let's try to skip gatekeepers

[davidiw]

my fear was that we'd hit some display issue :(

[movekevin]

my fear was that we'd hit some display issue :(

This case only happens if governance ever shortens the recurring lockup period.

[github-actions]

✅ Forge suite land_blocking success on bedfa8d555f1245010d7c2c703a6fbdeb24f1149

performance benchmark with full nodes : 7253 TPS, 5461 ms latency, 11400 ms p99 latency,(!) expired 540 out of 3097760 txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 843b204dce971d98449b82624f4f684c7a18b991 ==> bedfa8d555f1245010d7c2c703a6fbdeb24f1149

Compatibility test results for 843b204dce971d98449b82624f4f684c7a18b991 ==> bedfa8d555f1245010d7c2c703a6fbdeb24f1149 (PR)
1. Check liveness of validators at old version: 843b204dce971d98449b82624f4f684c7a18b991
compatibility::simple-validator-upgrade::liveness-check : 7958 TPS, 4757 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: bedfa8d555f1245010d7c2c703a6fbdeb24f1149
compatibility::simple-validator-upgrade::single-validator-upgrade : 5494 TPS, 6969 ms latency, 9400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: bedfa8d555f1245010d7c2c703a6fbdeb24f1149
compatibility::simple-validator-upgrade::half-validator-upgrade : 5305 TPS, 7343 ms latency, 9400 ms p99 latency,no expired txns
4. upgrading second batch to new version: bedfa8d555f1245010d7c2c703a6fbdeb24f1149
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7626 TPS, 4796 ms latency, 8600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 843b204dce971d98449b82624f4f684c7a18b991 ==> bedfa8d555f1245010d7c2c703a6fbdeb24f1149 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking