Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas] initial gas parameters for table operations #4659

Merged
merged 1 commit into from Sep 30, 2022

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented Sep 29, 2022

Previously I forgot to set the initial gas parameters for table. This gets them added and also makes sure that when a table op loads data from storage, it is charged in the same way as other global operations.


This change is Reviewable

@vgao1996 vgao1996 added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Sep 29, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on a02c7db64889585108f5f5c8de8187172ba63e88

performance benchmark with full nodes : 7348 TPS, 5423 ms latency, 9400 ms p99 latency,(!) expired 560 out of 3138540 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on 843b204dce971d98449b82624f4f684c7a18b991 ==> a02c7db64889585108f5f5c8de8187172ba63e88

Compatibility test results for 843b204dce971d98449b82624f4f684c7a18b991 ==> a02c7db64889585108f5f5c8de8187172ba63e88 (PR)
1. Check liveness of validators at old version: 843b204dce971d98449b82624f4f684c7a18b991
compatibility::simple-validator-upgrade::liveness-check : 7317 TPS, 4844 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: a02c7db64889585108f5f5c8de8187172ba63e88
compatibility::simple-validator-upgrade::single-validator-upgrade : 5145 TPS, 7861 ms latency, 10200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: a02c7db64889585108f5f5c8de8187172ba63e88
compatibility::simple-validator-upgrade::half-validator-upgrade : 5202 TPS, 7381 ms latency, 9400 ms p99 latency,no expired txns
4. upgrading second batch to new version: a02c7db64889585108f5f5c8de8187172ba63e88
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7462 TPS, 4907 ms latency, 8300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 843b204dce971d98449b82624f4f684c7a18b991 ==> a02c7db64889585108f5f5c8de8187172ba63e88 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants