[CLI] Respect --test-dir in aptos node run-local-testnet

[banool]

Description

Turns out we ignore this flag entirely. This PR fixes that.

Test Plan

rm -rf ~/.aptos
cargo run -p aptos -- node run-local-testnet --force-restart --assume-yes --test-dir /tmp/testnet

Before:

$ ls /tmp/testnet
$
$ ls ~/.aptos/testnet
0             mint.key      validator.log waypoint.txt

After:

$ ls /tmp/testnet
0             mint.key      validator.log waypoint.txt
$ ls ~/.aptos/testnet
ls: /Users/dport/.aptos/testnet: No such file or directory

[gregnazario]

Great catch!

[github-actions]

✅ Forge suite land_blocking success on 95b0af74de03b21dbd0c8a57135864a6b0b0ee63

performance benchmark with full nodes : 5757 TPS, 6910 ms latency, 10200 ms p99 latency,no expired txns
Test Ok

• Grafana dashboard
• Humio Logs
• Pyroscope Profiling
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> 95b0af74de03b21dbd0c8a57135864a6b0b0ee63

Compatibility test results for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> 95b0af74de03b21dbd0c8a57135864a6b0b0ee63 (PR)
Upgrade the nodes to version: 95b0af74de03b21dbd0c8a57135864a6b0b0ee63
framework_upgrade::framework-upgrade::full-framework-upgrade : 6821 TPS, 5573 ms latency, 9000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> 95b0af74de03b21dbd0c8a57135864a6b0b0ee63 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Pyroscope Profiling
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 95b0af74de03b21dbd0c8a57135864a6b0b0ee63

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 95b0af74de03b21dbd0c8a57135864a6b0b0ee63 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7757 TPS, 4939 ms latency, 7500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 95b0af74de03b21dbd0c8a57135864a6b0b0ee63
compatibility::simple-validator-upgrade::single-validator-upgrade : 4789 TPS, 8171 ms latency, 10800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 95b0af74de03b21dbd0c8a57135864a6b0b0ee63
compatibility::simple-validator-upgrade::half-validator-upgrade : 4738 TPS, 8353 ms latency, 10900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 95b0af74de03b21dbd0c8a57135864a6b0b0ee63
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6954 TPS, 5492 ms latency, 9800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 95b0af74de03b21dbd0c8a57135864a6b0b0ee63 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Pyroscope Profiling
• Test runner output
• Test run is land-blocking