-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tf][indexer] option for RDS to be publicly accessible #774
Conversation
vpc_id = module.validator.vpc_id | ||
|
||
db_password = var.indexer_db_password | ||
db_password = var.indexer_db_password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the public access only protected by password? do we have any IP gating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added var that controls the security group: db_sources_ipv4
/help |
Bors help and documentationBors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's General
CommandsBors actions can be triggered by posting a comment which includes a line of the form
OptionsOptions for Pull Requests are configured through the application of labels. |
/land |
Forge run: https://circleci.com/gh/aptos-labs/aptos-core/13380 |
New variable(s) to enable RDS to be publicly accessible, making it easier to plug into anlaytics tooling
indexer_db_publicly_accessible
whenenable_indexer = true
, and will also determine which subnets to provision ondb_publicly_accessible
Also, includes a small fix for testnet REST API when validator-lite is enabled