Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tf][indexer] option for RDS to be publicly accessible #774

Merged
merged 3 commits into from
May 4, 2022

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented May 2, 2022

New variable(s) to enable RDS to be publicly accessible, making it easier to plug into anlaytics tooling

  • For testnet TF: indexer_db_publicly_accessible when enable_indexer = true, and will also determine which subnets to provision on
  • For indexer TF: db_publicly_accessible

Also, includes a small fix for testnet REST API when validator-lite is enabled

vpc_id = module.validator.vpc_id

db_password = var.indexer_db_password
db_password = var.indexer_db_password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the public access only protected by password? do we have any IP gating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added var that controls the security group: db_sources_ipv4

@rustielin rustielin requested a review from sherry-x May 3, 2022 20:27
@rustielin
Copy link
Contributor Author

/help

@aptos-bot
Copy link
Contributor

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.

General

  • This project's Merge Queue can be found here.
  • This project requires PRs to be Reviewed and Approved before they can be queued for merging.
  • Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands

Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command Action Description
Land land, merge attempt to land or merge a PR
Canary canary, try canary a PR by performing all checks without merging
Cancel cancel, stop stop an in-progress land
Cherry Pick cherry-pick <target> cherry-pick a PR into <target> branch
Priority priority set the priority level for a PR (high, normal, low)
Help help, h show this help message

Options

Options for Pull Requests are configured through the application of labels.

          Option           Description
label: bors-high-priority Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.
label: bors-low-priority Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.
label: bors-squash Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

@rustielin
Copy link
Contributor Author

/land

@aptos-bot
Copy link
Contributor

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/13380
Forge test result: all up : 1400 TPS, 3127 ms latency, 4650 ms p99 latency,no expired txns

@aptos-bot aptos-bot closed this in 17f7877 May 4, 2022
@aptos-bot aptos-bot merged commit 17f7877 into aptos-labs:main May 4, 2022
gregnazario pushed a commit to gregnazario/aptos-core that referenced this pull request May 5, 2022
dr-smo pushed a commit to metaworkz/aptos-core that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants