Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc-ecosystem/grpc-gateway #3028

Merged

Conversation

takumin
Copy link
Contributor

@takumin takumin commented Apr 19, 2022

Added packages:

@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Apr 19, 2022
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Apr 19, 2022

I've added some modification.

refactor: change directory path according to the package name 14e7cb2
fix: support macOS / arm64 e6a5b0a
refactor: remove file's src 3cbdfff

refactor: change directory path according to the package name

AS IS:

pkgs/grpc-ecosystem/grpc-gateway

TO BE

  • pkgs/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
  • pkgs/grpc-ecosystem/grpc-gateway/protoc-gen-openapiv2

fix: support macOS / arm64

The asset for M1 Mac isn't released but aqua can supports M1 Mac with Rosetta2.
So I've fixed supported_if.

refactor: remove file's src

We don't have to specify files' src in case of packages whose format is raw.

@takumin
Copy link
Contributor Author

takumin commented Apr 19, 2022

Oops...I didn't know how to do it😭
Thank you for fixing it!
Subsequent pull requests will be fixed as soon as they return home.

@suzuki-shunsuke suzuki-shunsuke added this to the v2.6.0 milestone Apr 19, 2022
@suzuki-shunsuke suzuki-shunsuke merged commit b0a8d16 into aquaproj:main Apr 19, 2022
@takumin takumin deleted the feat-grpc-ecosystem-grpc-gateway branch April 19, 2022 09:24
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants