fix: set GOOS=windows when building go_install package with AQUA_GOOS=windows

pkg/cli/exec.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/aquaproj/aqua/v2/pkg/config"
 	"github.com/aquaproj/aqua/v2/pkg/controller"
+	"github.com/aquaproj/aqua/v2/pkg/runtime"
 	"github.com/urfave/cli/v2"
 )
 
@@ -53,7 +54,7 @@ func (r *Runner) execAction(c *cli.Context) error {
 	if err := r.setParam(c, "exec", param); err != nil {
 		return fmt.Errorf("parse the command line arguments: %w", err)
 	}
-	ctrl := controller.InitializeExecCommandController(c.Context, param, http.DefaultClient, r.Runtime)
+	ctrl := controller.InitializeExecCommandController(c.Context, param, http.DefaultClient, runtime.NewR())
 	exeName, args, err := parseExecArgs(c.Args().Slice())
 	if err != nil {
 		return err

pkg/config/package.go

@@ -189,7 +189,7 @@ func getArch(rosetta2, windowsARMEmulation bool, replacements registry.Replaceme
 		// Rosetta 2
 		return replace("amd64", replacements)
 	}
-	if windowsARMEmulation && rt.GOOS == "windows" && rt.GOARCH == "arm64" {
+	if windowsARMEmulation && rt.IsWindows() && rt.GOARCH == "arm64" {
 		// Windows ARM Emulation
 		return replace("amd64", replacements)
 	}

pkg/controller/cp/copy.go

@@ -11,7 +11,7 @@ import (
 
 func (c *Controller) copy(logE *logrus.Entry, param *config.Param, findResult *which.FindResult, exeName string) error {
 	p := filepath.Join(param.Dest, exeName)
-	if c.runtime.GOOS == "windows" && filepath.Ext(exeName) == "" {
+	if c.runtime.IsWindows() && filepath.Ext(exeName) == "" {
 		p += ".exe"
 	}
 	logE.WithFields(logrus.Fields{

pkg/controller/install/install.go

@@ -58,7 +58,7 @@ func (c *Controller) mkBinBatDir() error {
 	if err := osfile.MkdirAll(c.fs, rootBin); err != nil {
 		return fmt.Errorf("create the directory: %w", err)
 	}
-	if c.runtime.GOOS == "windows" {
+	if c.runtime.IsWindows() {
 		if err := osfile.MkdirAll(c.fs, filepath.Join(c.rootDir, "bat")); err != nil {
 			return fmt.Errorf("create the directory: %w", err)
 		}

pkg/cosign/exe_path.go

@@ -14,7 +14,7 @@ type ParamExePath struct {
 
 func ExePath(param *ParamExePath) string {
 	assetName := fmt.Sprintf("cosign-%s-%s", param.Runtime.GOOS, param.Runtime.GOARCH)
-	if param.Runtime.GOOS == "windows" {
+	if param.Runtime.IsWindows() {
 		assetName += ".exe"
 	}
 	return filepath.Join(param.RootDir, "pkgs", "github_release", "github.com", "sigstore", "cosign", Version, assetName, assetName)

pkg/cosign/verify.go

@@ -46,7 +46,7 @@ func NewVerifier(executor Executor, fs afero.Fs, downloader download.ClientAPI,
 			Runtime: rt,
 		}),
 		// assets for windows/arm64 aren't released.
-		disabled: rt.GOOS == "windows" && rt.GOARCH == "arm64",
+		disabled: rt.IsWindows() && rt.GOARCH == "arm64",
 	}
 }
 

pkg/installpackage/aqua.go

@@ -28,7 +28,7 @@ func (is *Installer) InstallAqua(ctx context.Context, logE *logrus.Entry, versio
 			Format:    "tar.gz",
 			Overrides: []*registry.Override{
 				{
-					GOOS:   "windows",
+					GOOS:   osWindows,
 					Format: "zip",
 				},
 			},
@@ -132,7 +132,7 @@ func (is *Installer) InstallAqua(ctx context.Context, logE *logrus.Entry, versio
 		return fmt.Errorf("get the executable file path: %w", err)
 	}
 
-	if is.runtime.GOOS == "windows" {
+	if is.runtime.IsWindows() {
 		return is.Copy(filepath.Join(is.rootDir, "bin", "aqua.exe"), exePath)
 	}
 

pkg/installpackage/const.go

@@ -0,0 +1,5 @@
+package installpackage
+
+const (
+	osWindows = "windows"
+)

pkg/installpackage/download.go

@@ -57,7 +57,7 @@ func (is *Installer) download(ctx context.Context, logE *logrus.Entry, param *Do
 	pkgInfo := param.Package.PackageInfo
 
 	if pkgInfo.Type == "go_install" {
-		return is.downloadGoInstall(ctx, ppkg, param.Dest, logE)
+		return is.downloadGoInstall(ctx, logE, ppkg, param.Dest, is.runtime.GOOS)
 	}
 
 	if pkgInfo.Type == "cargo" {

pkg/installpackage/go_install.go

@@ -9,7 +9,7 @@ import (
 )
 
 type GoInstallInstaller interface {
-	Install(ctx context.Context, path, gobin string) error
+	Install(ctx context.Context, path, gobin, goos string) error
 }
 
 type GoInstallInstallerImpl struct {
@@ -22,15 +22,18 @@ func NewGoInstallInstallerImpl(exec Executor) *GoInstallInstallerImpl {
 	}
 }
 
-func (is *GoInstallInstallerImpl) Install(ctx context.Context, path, gobin string) error {
-	_, err := is.exec.ExecWithEnvs(ctx, "go", []string{"install", path}, []string{"GOBIN=" + gobin})
-	if err != nil {
+func (is *GoInstallInstallerImpl) Install(ctx context.Context, path, gobin, goos string) error {
+	envs := []string{"GOBIN=" + gobin}
+	if goos == "windows" {
+		envs = append(envs, "GOOS=windows")
+	}
+	if _, err := is.exec.ExecWithEnvs(ctx, "go", []string{"install", path}, envs); err != nil {
 		return fmt.Errorf("install a go package: %w", err)
 	}
 	return nil
 }
 
-func (is *Installer) downloadGoInstall(ctx context.Context, pkg *config.Package, dest string, logE *logrus.Entry) error {
+func (is *Installer) downloadGoInstall(ctx context.Context, logE *logrus.Entry, pkg *config.Package, dest, goos string) error {
 	p, err := pkg.RenderPath()
 	if err != nil {
 		return fmt.Errorf("render Go Module Path: %w", err)
@@ -40,7 +43,7 @@ func (is *Installer) downloadGoInstall(ctx context.Context, pkg *config.Package,
 		"gobin":           dest,
 		"go_package_path": goPkgPath,
 	}).Info("Installing a Go tool")
-	if err := is.goInstallInstaller.Install(ctx, goPkgPath, dest); err != nil {
+	if err := is.goInstallInstaller.Install(ctx, goPkgPath, dest, goos); err != nil {
 		return fmt.Errorf("build Go tool: %w", err)
 	}
 	return nil

pkg/installpackage/mock_go_install.go

@@ -8,6 +8,6 @@ type MockGoInstallInstaller struct {
 	Err error
 }
 
-func (m *MockGoInstallInstaller) Install(ctx context.Context, path, gobin string) error {
+func (m *MockGoInstallInstaller) Install(ctx context.Context, path, gobin, goos string) error {
 	return m.Err
 }

pkg/runtime/runtime.go

@@ -29,6 +29,10 @@ func (rt *Runtime) Env() string {
 	return fmt.Sprintf("%s/%s", rt.GOOS, rt.GOARCH)
 }
 
+func (rt *Runtime) IsWindows() bool {
+	return rt.GOOS == "windows"
+}
+
 func goos() string {
 	if s := os.Getenv("AQUA_GOOS"); s != "" {
 		return s

pkg/slsa/exe_path.go

@@ -14,7 +14,7 @@ type ParamExePath struct {
 
 func ExePath(param *ParamExePath) string {
 	assetName := fmt.Sprintf("slsa-verifier-%s-%s", param.Runtime.GOOS, param.Runtime.GOARCH)
-	if param.Runtime.GOOS == "windows" {
+	if param.Runtime.IsWindows() {
 		assetName += ".exe"
 	}
 	return filepath.Join(param.RootDir, "pkgs", "github_release", "github.com", "slsa-framework", "slsa-verifier", Version, assetName, assetName)