Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Object lock object retention #111

Merged
merged 1 commit into from Mar 2, 2023

Conversation

giubacc
Copy link

@giubacc giubacc commented Jan 26, 2023

Object retention features implemented:

  • Default Bucket'retention configuration for both GOVERNANCE/COMPLIANCE
    modes.
  • Default bucket's retention mode on objects when no
    explicit retention is specified on put_object().
  • Explicit retention mode set on object's versions with put_object().
  • Tested expected behavior on objects for both GOVERNANCE/COMPLIANCE modes.
  • Tested expected behavior for deletions with BypassGovernanceRetention flag set.

Fixes: https://github.com/aquarist-labs/s3gw/issues/327
Signed-off-by: Giuseppe Baccini giuseppe.baccini@suse.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@giubacc giubacc self-assigned this Jan 26, 2023
@giubacc giubacc force-pushed the object-lock-object-retention branch from f880a34 to 56de582 Compare January 26, 2023 14:48
@giubacc giubacc force-pushed the object-lock-object-retention branch from 56de582 to 1ba5cd3 Compare February 7, 2023 11:06
@github-actions github-actions bot added build/ops kind/documentation Improvements or additions to documentation labels Feb 7, 2023
@giubacc giubacc force-pushed the object-lock-object-retention branch from 1ba5cd3 to 286fceb Compare February 8, 2023 16:46
@jecluis jecluis added area/rgw-sfs RGW & SFS related kind/feature New functionality or support for something and removed build/ops kind/documentation Improvements or additions to documentation labels Feb 10, 2023
@jecluis jecluis modified the milestone: v0.13.0 Feb 15, 2023
@jhmarina jhmarina added this to the v0.13.0 milestone Feb 20, 2023
@github-actions github-actions bot added the needs-rebase Changes need a rebase label Feb 20, 2023
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions github-actions bot added documentation rgw and removed needs-rebase Changes need a rebase labels Feb 21, 2023
@giubacc giubacc force-pushed the object-lock-object-retention branch 2 times, most recently from bca5ba5 to 6578d9f Compare February 23, 2023 14:18
@giubacc giubacc marked this pull request as ready for review February 23, 2023 14:39
@giubacc giubacc requested review from jecluis and removed request for jecluis February 23, 2023 14:39
Copy link
Member

@irq0 irq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: Tested not verified? Verification means something way stronger (https://en.wikipedia.org/wiki/Software_verification)

Lines are a bit long
See: https://github.com/ceph/ceph/blob/main/CodingStyle
https://google.github.io/styleguide/cppguide.html
Consider running the python code through black

src/rgw/driver/sfs/writer.cc Outdated Show resolved Hide resolved
@giubacc
Copy link
Author

giubacc commented Feb 28, 2023

Commit message: Tested not verified? Verification means something way stronger (https://en.wikipedia.org/wiki/Software_verification)

Lines are a bit long See: https://github.com/ceph/ceph/blob/main/CodingStyle https://google.github.io/styleguide/cppguide.html Consider running the python code through black

Rephrased with "Tested" and formatted py code with black

@giubacc giubacc requested a review from irq0 February 28, 2023 09:05
Object-Locking features implemented:

 - Default Bucket'retention configuration for both GOVERNANCE/COMPLIANCE
   modes.
 - Default bucket's retention mode on objects when no
   explicit retention is specified on put_object().
 - Explicit retention mode set on object's versions with put_object().
 - Tested expected behavior on objects for both GOVERNANCE/COMPLIANCE modes.
 - Tested expected behavior for deletions with BypassGovernanceRetention flag set.

Fixes: https://github.com/aquarist-labs/s3gw/issues/327
Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
@giubacc giubacc force-pushed the object-lock-object-retention branch from 3bd711d to dd652e3 Compare March 1, 2023 10:45
@giubacc giubacc merged commit 3ae57a9 into aquarist-labs:s3gw Mar 2, 2023
irq0 pushed a commit that referenced this pull request Mar 17, 2023
Problem: Get object for s3cmd gives checksum mismatch
	 warning during get object from s3

Solution: Bl is updated in every iteration. So the
	  new data should be  stored from the 0th index every
	  time in bl. But in code we are passing 'off' to
	  handle_data function. This results in writing from
	  offset index and result in checksum mismatch,
	  passing 0 in place of offset in handle_data function

Signed-off-by: dharmendra-jyani <dharmendra.jyani@seagate.com>

Co-authored-by: kupranay <pranay.kumar@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/rgw-sfs RGW & SFS related documentation kind/feature New functionality or support for something rgw
Projects
Archived in project
4 participants