-
Notifications
You must be signed in to change notification settings - Fork 10
Object lock object retention #111
Object lock object retention #111
Conversation
f880a34
to
56de582
Compare
56de582
to
1ba5cd3
Compare
1ba5cd3
to
286fceb
Compare
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
286fceb
to
e4a7675
Compare
bca5ba5
to
6578d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message: Tested not verified? Verification means something way stronger (https://en.wikipedia.org/wiki/Software_verification)
Lines are a bit long
See: https://github.com/ceph/ceph/blob/main/CodingStyle
https://google.github.io/styleguide/cppguide.html
Consider running the python code through black
6578d9f
to
3bd711d
Compare
Rephrased with "Tested" and formatted py code with black |
Object-Locking features implemented: - Default Bucket'retention configuration for both GOVERNANCE/COMPLIANCE modes. - Default bucket's retention mode on objects when no explicit retention is specified on put_object(). - Explicit retention mode set on object's versions with put_object(). - Tested expected behavior on objects for both GOVERNANCE/COMPLIANCE modes. - Tested expected behavior for deletions with BypassGovernanceRetention flag set. Fixes: https://github.com/aquarist-labs/s3gw/issues/327 Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
3bd711d
to
dd652e3
Compare
Problem: Get object for s3cmd gives checksum mismatch warning during get object from s3 Solution: Bl is updated in every iteration. So the new data should be stored from the 0th index every time in bl. But in code we are passing 'off' to handle_data function. This results in writing from offset index and result in checksum mismatch, passing 0 in place of offset in handle_data function Signed-off-by: dharmendra-jyani <dharmendra.jyani@seagate.com> Co-authored-by: kupranay <pranay.kumar@seagate.com>
Object retention features implemented:
modes.
explicit retention is specified on put_object().
Fixes: https://github.com/aquarist-labs/s3gw/issues/327
Signed-off-by: Giuseppe Baccini giuseppe.baccini@suse.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows