Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistently use "Issues and feedback" section #106

Merged

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Jul 23, 2020

Description

  • kube enforcer uses an "Issues and feedback" section and no
    "Support" section
    • I think this section is clearer than "Support"; I assume a "Support"
      section may link to a customer service email or ticketing system,
      not to standard GitHub issues
  • enforcer had both an "Issues and feedback" section and a "Support"
    section
    • remove the duplicative "Support" section
  • server had a "Support" section but wasn't linked in ToC
    • add "Issues and feedback" and link in ToC
  • scanner had a "Support" section
    • change to "Issues and feedback"
  • main repo root README had a "Support" section
    • change to "Issues and feedback"
    • also fix heading to be an H2 as only one H1 is semantically allowed
      per page
      • and all other docs use an H2 for this section

Tags

Related to #105 and #108 , just a lot of consistency issues in general. In this case, unlike #105, they're not harmful and have low impact, but generally good to be consistent anyway.

- kube enforcer uses an "Issues and feedback" section and no
  "Support" section
  - I think this section is clearer than "Support"; I assume a "Support"
    section may link to a customer service email or ticketing system,
    not to standard GitHub issues
- enforcer had both an "Issues and feedback" section _and_ a "Support"
  section
  - remove the duplicative "Support" section
- server had a "Support" section but wasn't linked in ToC
  - add "Issues and feedback" and link in ToC
- scanner had a "Support" section
  - change to "Issues and feedback"
- main repo root README had a "Support" section
  - change to "Issues and feedback"
  - also fix heading to be an H2 as only one H1 is semantically allowed
    per page
    - and all other docs use an H2 for this section
- only Enforcer had plural "Charts", but it is only a single chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants