fix/docs: dated TLS auth link in KubeEnforcer docs' ToC #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2d3b1eb changed the heading slightly, but didn't change the respective entry in the ToC - this updates the ToC entry to match the heading
agilgur5
force-pushed
the
fix-kubeenforcer-incorrect-toc-link
branch
from
4e71f18
to
7f4f0ea
Compare
agilgur5
changed the title
|
duplicate |
|
@niso120b Er, this wasn't a duplicate... the bug still very much exists in the docs. Also if it were a duplicate, I would expect you to specify a reference to the PR or commit it duplicates. This does not duplicate any of my other PRs that you merged or closed. Maybe you meant it had conflicts, which it almost certainly did with #108 that standardized the ToC and was merged first. I have rebased with the main branch and fixed those conflicts. It will likely conflict with #105 as well since that moves this section under its Pre-reqs section. Please re-open this as it fixes a bug. |
|
Noting that this was re-opened and merged as #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
but didn't change the respective entry in the ToC
Tags
Follow-up to #93