Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell script support #108

Merged
merged 3 commits into from Nov 23, 2020
Merged

Add shell script support #108

merged 3 commits into from Nov 23, 2020

Conversation

yoavrotems
Copy link
Contributor

Add option to run scripts in audit command

Add option to run scripts in audit command
Add check for runAudit (running shall script and single commands)
@yoavrotems
Copy link
Contributor Author

Thanks to aquasecurity/kube-bench#610 @mozillazg

Change from sh to bin/sh
yoavrotems added a commit to aquasecurity/linux-bench that referenced this pull request Nov 22, 2020
Bench-common is now supports scripts in audit 
aquasecurity/bench-common#108
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #108 (dd3ad04) into master (f2b98ad) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   62.97%   62.53%   -0.44%     
==========================================
  Files          14       14              
  Lines         794      702      -92     
==========================================
- Hits          500      439      -61     
+ Misses        265      233      -32     
- Partials       29       30       +1     
Impacted Files Coverage Δ
check/check.go 82.82% <100.00%> (-0.33%) ⬇️
check/bench.go 76.00% <0.00%> (-3.67%) ⬇️
outputter/json.go 76.47% <0.00%> (-3.53%) ⬇️
outputter/writer.go 68.75% <0.00%> (-3.48%) ⬇️
auditeval/test.go 80.90% <0.00%> (-1.75%) ⬇️
app.go 23.40% <0.00%> (-1.13%) ⬇️
util/util.go 24.69% <0.00%> (-0.80%) ⬇️
check/controls.go 72.63% <0.00%> (-0.65%) ⬇️
outputter/junit.go 64.70% <0.00%> (-0.30%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b98ad...dd3ad04. Read the comment docs.

Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lizrice lizrice merged commit dfdc30c into master Nov 23, 2020
@yoavrotems yoavrotems deleted the run-shell-scripts branch December 17, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants