Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend default kubelet configlist to fit to current AWS EKS setups (1.29 and above) #1637

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Extend default kubelet configlist to fit to current AWS EKS setups (1.29 and above) #1637

merged 2 commits into from
Oct 4, 2024

Conversation

mmuth
Copy link
Contributor

@mmuth mmuth commented Jun 27, 2024

@mmuth
Extend default kubelet configlist to fit AWS EKS
a42fe97 
- the latest default Kubernetes setup of AWS has
  its kubelet config path in the added location.
  Proposing to extend the list of scanned paths in
  order to make kube-bench execution more painless
  and "quick start like" in default setups.
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mmuth mmuth changed the title Extend default kubelet configlist to fit AWS EKS Extend default kubelet configlist to fit to current AWS EKS setups (1.29 and above) Jun 27, 2024
mozillazg
mozillazg approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@mmuth
Copy link
Contributor Author

mmuth commented Jul 30, 2024

@chen-keinan could you also take a look on this? thanks :)

@mozillazg
Copy link
Collaborator

@chen-keinan ping~

afdesk
afdesk approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@afdesk afdesk merged commit e8562f2 into aquasecurity:main Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozillazg mozillazg mozillazg approved these changes

@afdesk afdesk afdesk approved these changes

@chen-keinan chen-keinan Awaiting requested review from chen-keinan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EKS default setup clusters are not benchmarked correctly (config path missing)
4 participants
@mmuth @CLAassistant @mozillazg @afdesk