Fixes issue #391: Replaced calling docker directly by using "make build-docker" #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
======================================
Coverage 65.8% 65.8%
======================================
Files 11 11
Lines 1000 1000
======================================
Hits 658 658
Misses 305 305
Partials 37 37Continue to review full report at Codecov.
|
danielpacak
reviewed
Nov 26, 2019
| @@ -15,7 +15,7 @@ before_install: | |||
|
|
|||
| script: | |||
| - GO111MODULE=on go test ./... | |||
| - docker build --tag kube-bench . | |||
| - IMAGE_NAME=kube-bench make build-docker | |||
There was a problem hiding this comment.
Is there any reason to keep IMAGE_NAME var outside of makefile?
There was a problem hiding this comment.
The use of the IMAGE_NAME is to make sure the line following that one continues to work.
There was a problem hiding this comment.
All right, I thought that the defaults hardcoded in makefile are enough, so when I run make build-docker it would work the same way as on Travis.
This was referenced Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #391:
Replaced calling docker directly by using "make build-docker"