Refactor: remove ContinueWithError #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Continue with error function
|
Tests passed |
lizrice
suggested changes
Jun 25, 2020
|
@yoavrotems Please can you revisit the name of this PR? Something like "Refactor: remove ContinueWithError" would be more meaningful to someone else looking at the PR list |
|
@lizrice I changed but apparently didn't apply my change... |
Co-authored-by: Liz Rice <liz@lizrice.com>
Remove unnecessary ')'
removed fmt.Fprintf(os.Stderr, "%s: %s", cmd.Args, err) since it wasn't suppose to print.
option --no-ri and --no-doc are deprecated we have to use --no-document instead. rubygems/heroku-buildpack-bundler2#1 (comment)
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 65.57% 69.41% +3.83%
==========================================
Files 12 12
Lines 1101 1213 +112
==========================================
+ Hits 722 842 +120
+ Misses 339 333 -6
+ Partials 40 38 -2
Continue to review full report at Codecov.
|
caruccio
pushed a commit
to getupcloud/kube-bench
that referenced
this pull request
Feb 19, 2021
* Update util.go Remove Continue with error function * Update cmd/util.go Co-authored-by: Liz Rice <liz@lizrice.com> * Update util.go * Update util.go Remove unnecessary ')' * Update util.go removed fmt.Fprintf(os.Stderr, "%s: %s", cmd.Args, err) since it wasn't suppose to print. * Update util.go * Update .travis.yml option --no-ri and --no-doc are deprecated we have to use --no-document instead. rubygems/heroku-buildpack-bundler2#1 (comment) Co-authored-by: Liz Rice <liz@lizrice.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Continue with error function