Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup configuration refactor #289

Closed
3 tasks
itaysk opened this issue Dec 29, 2019 · 0 comments · Fixed by #310
Closed
3 tasks

cleanup configuration refactor #289

itaysk opened this issue Dec 29, 2019 · 0 comments · Fixed by #310

Comments

@itaysk
Copy link
Collaborator

itaysk commented Dec 29, 2019 •
edited
Loading

This issue is to extract the todo items from the code of #283 in the file kube-hunter.py to a proper issue.

  • L18: move log level parsing to conf module
  • L25-L29, L39-42: move this mapping to report module, consider using factory for abstraction
  • L32-L26: move report config handling to conf module
@itaysk itaysk mentioned this issue Dec 29, 2019
Merged
2 tasks
@iyehuda iyehuda mentioned this issue Feb 16, 2020
Closed
2 tasks
mormamn added a commit to mormamn/kube-hunter that referenced this issue Feb 20, 2020
@mormamn
Cleanup configuration refactor
7b3515c 
This PR reorganize the config files, and argparse.
resolves aquasecurity#289.
mormamn added a commit to mormamn/kube-hunter that referenced this issue Feb 24, 2020
@mormamn
This PR reorganize the config files, and argparse.
06e74e3 
resolves aquasecurity#289
@mormamn mormamn mentioned this issue Feb 24, 2020
Merged
3 tasks
iyehuda pushed a commit that referenced this issue Feb 25, 2020
@mormamn
Cleanup conf refactor (#310)
a8128b7 
Reorganize config files, and argparse.
Resolves #289
Resolves #292
py-go pushed a commit to py-go/kube-hunter that referenced this issue Aug 29, 2021
@krol3
fix(kube-bench): Skip windows nodes (aquasecurity#289)
b73bc8c 
Resolves: aquasecurity#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup conf refactor mormamn/kube-hunter
1 participant
@itaysk