Refactor configuration #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making conf module standalone enables using it without previous initialization (e.g, from main script). This way, we can run `pytest` directly without conf init via `runtest.py`, which now can be deprecated. Resolves #234
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=========================================
+ Coverage 58.07% 58.87% +0.8%
=========================================
Files 38 39 +1
Lines 1994 2011 +17
=========================================
+ Hits 1158 1184 +26
+ Misses 836 827 -9
Continue to review full report at Codecov.
|
The `install_imports.py` script was made to find 3rd party libs dynamically and pip install them. Now that we have well declared requirements*.txt files, we dont need this script.
The previous src root package name was too generic and not unique, so it can be used as external name. Change `src` to `kube_hunter` so it can be referenced in a clear way. Addtional changes made on the way: * Make imports absolute * Formatting Relates to #185
itaysk
reviewed
Dec 16, 2019
itaysk
approved these changes
Dec 29, 2019
knqyf263
approved these changes
Dec 29, 2019
invidian
added a commit
to kinvolk/kube-hunter
that referenced
this pull request
Jan 21, 2020
This reverts commit fe3dba9.
Closed
py-go
pushed a commit
to py-go/kube-hunter
that referenced
this pull request
Aug 29, 2021
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved configuration into a separate package and break dependencies of
__main__module.This way we can run external tools on kube-hunter (e.g., pytest, profiling, etc.).
runtest.py may now be deprecated and removed.
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Fixes #234
Contribution checklist
Notes
This PR was initiated by @RaitoBezarius, thank you for your work!