Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: k8s security context permissions #279

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: k8s security context permissions #279

merged 1 commit into from
Feb 7, 2022

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Feb 5, 2022

Fix issues related to k8s manifest in poste-ui #273

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #279 (d6730ec) into main (ca72375) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files          28       28           
  Lines        1112     1112           
=======================================
  Hits          966      966           
  Misses         88       88           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca72375...d6730ec. Read the comment docs.

@sealneaward
Copy link

This lines up with the error I was having the other week. I can test these changes on my cluster to see if the error goes away.

@sealneaward
Copy link

sealneaward commented Feb 7, 2022 •
edited

The proposed changes work on my cluster and fix the problem I was having.

simar7
simar7 reviewed Feb 7, 2022
View reviewed changes
deploy/kubernetes/postee.yaml
@@ -154,11 +154,15 @@ spec:
command:
- /bin/chown
- -R
- "1099"
- /server/database
- "1099:1099"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's 1099? I'm not familiar with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the answer - looks like we've been using this for Postee.

@simar7
Copy link
Member

simar7 commented Feb 7, 2022

The proposed changes work on my cluster and fix the problem I was having.

thanks @sealneaward for your feedback

@simar7 simar7 self-requested a review February 7, 2022 23:14
@simar7 simar7 merged commit ca424f6 into aquasecurity:main Feb 7, 2022
kairi003 pushed a commit to kairi003/postee that referenced this pull request Oct 18, 2022
@erikgb
chore: use controller-gen to generate CRDs from Go markers (aquasecur…
94e5fc6 
…ity#279)

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@jerbia jerbia Awaiting requested review from jerbia

@afdesk afdesk Awaiting requested review from afdesk

@AndreyLevchenko AndreyLevchenko Awaiting requested review from AndreyLevchenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krol3 @sealneaward @simar7