-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required Column added #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks it looks awesome, just suggested a few changes.
docs/actions.md
Outdated
*issuetype*| Optional: issue type, e.g., Bug | | ||
*labels*| Optional: comma separated list of labels that will be assigned to ticket, e.g., ["label1", "label2"]| | ||
*sprint*| Optional: Sprint name, e.g., "3.5 Sprint 8" | | ||
Key | Description | Possible Values | Required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key | Description | Possible Values | Required | |
Key | Description | Supported Values | Required |
Or
Key | Description | Possible Values | Required | |
Key | Description | Values | Required |
@simar7 I think the word Possible
is a little ambiguos. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah your suggestion makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So which should I select
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave it at Values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
docs/actions.md
Outdated
*sprint*| Optional: Sprint name, e.g., "3.5 Sprint 8" | | ||
Key | Description | Possible Values | Required | ||
--------------|----------------------|-----------------|---------- | ||
*url* | Jira project url | | YES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*url* | Jira project url | | YES | |
*url* | Jira project url | | Yes |
I think it's better use lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay @krol3
1:- "Yes"
2:- "yes"
which one will be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd pick 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @souravsk , a few comments below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Welcome @simar7 if any else I do please let me know |
thanks @souravsk - I'm in the process of writing a design document that should highlight where we can improve Postee today. It's currently a PR in progress. I plan to create actionable issues from this document, that external contributors like you can pick up and work on. https://github.com/aquasecurity/postee/pull/466/files |
it looks like it is already merged |
Create the PR for this issue:-
Add information about optional/required fields in Actions documentation #380