Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve gh api rate limits #82

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

marcofranssen
Copy link
Contributor

@marcofranssen marcofranssen commented Oct 19, 2022

  • Change entrypoint shebash to best practice
  • Resolve some shellcheck issues
  • Reduce amount of API calls to GitHub
  • Add GitHub token to api requests

Resolves #81

@owenrumney probably you want to do a similar PR on the other GH actions to resolve it there as well.

@marcofranssen
Copy link
Contributor Author

Can anyone look at this PR? Without this fix the action is basically useless.

@@ -1,6 +1,7 @@
FROM public.ecr.aws/docker/library/alpine:3.12

RUN apk --no-cache --update add bash git \
jq curl \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required to reduce the amount of api calls
as well to pass in the Authorization header to have higher rate limits.

@liamg liamg merged commit f2c4d29 into aquasecurity:main Oct 31, 2022
@marcofranssen marcofranssen deleted the resolve-gh-api-rate-limits branch November 1, 2022 08:27
3ware-release bot pushed a commit to 3ware/workflows that referenced this pull request Feb 2, 2023
## [1.0.2](v1.0.1...v1.0.2) (2023-02-02)

### Chores

* **deps:** bump amannn/action-semantic-pull-request from 4 to 5 ([#7](#7)) ([3958e45](3958e45)), closes [#205](https://github.com/3ware/workflows/issues/205) [#205](https://github.com/3ware/workflows/issues/205) [#194](https://github.com/3ware/workflows/issues/194) [#179](https://github.com/3ware/workflows/issues/179) [#177](https://github.com/3ware/workflows/issues/177) [#174](https://github.com/3ware/workflows/issues/174) [#207](https://github.com/3ware/workflows/issues/207) [#205](https://github.com/3ware/workflows/issues/205) [#205](https://github.com/3ware/workflows/issues/205) [#194](https://github.com/3ware/workflows/issues/194) [#179](https://github.com/3ware/workflows/issues/179) [#177](https://github.com/3ware/workflows/issues/177) [#174](https://github.com/3ware/workflows/issues/174) [#208](https://github.com/3ware/workflows/issues/208) [#209](https://github.com/3ware/workflows/issues/209) [#207](https://github.com/3ware/workflows/issues/207) [#206](https://github.com/3ware/workflows/issues/206)
* **deps:** bump aquasecurity/tfsec-pr-commenter-action from 1.2.0 to 1.3.1 ([#9](#9)) ([4f17bf3](4f17bf3)), closes [#85](#85) [aquasecurity/tfsec-pr-commenter-action#86](aquasecurity/tfsec-pr-commenter-action#86) [aquasecurity/tfsec-pr-commenter-action#86](aquasecurity/tfsec-pr-commenter-action#86) [aquasecurity/tfsec-pr-commenter-action#65](aquasecurity/tfsec-pr-commenter-action#65) [aquasecurity/tfsec-pr-commenter-action#64](aquasecurity/tfsec-pr-commenter-action#64) [aquasecurity/tfsec-pr-commenter-action#59](aquasecurity/tfsec-pr-commenter-action#59) [aquasecurity/tfsec-pr-commenter-action#63](aquasecurity/tfsec-pr-commenter-action#63) [aquasecurity/tfsec-pr-commenter-action#78](aquasecurity/tfsec-pr-commenter-action#78) [aquasecurity/tfsec-pr-commenter-action#76](aquasecurity/tfsec-pr-commenter-action#76) [aquasecurity/tfsec-pr-commenter-action#74](aquasecurity/tfsec-pr-commenter-action#74) [aquasecurity/tfsec-pr-commenter-action#82](aquasecurity/tfsec-pr-commenter-action#82) [aquasecurity/tfsec-pr-commenter-action#65](aquasecurity/tfsec-pr-commenter-action#65) [aquasecurity/tfsec-pr-commenter-action#59](aquasecurity/tfsec-pr-commenter-action#59) [aquasecurity/tfsec-pr-commenter-action#63](aquasecurity/tfsec-pr-commenter-action#63) [aquasecurity/tfsec-pr-commenter-action#78](aquasecurity/tfsec-pr-commenter-action#78) [aquasecurity/tfsec-pr-commenter-action#76](aquasecurity/tfsec-pr-commenter-action#76) [aquasecurity/tfsec-pr-commenter-action#74](aquasecurity/tfsec-pr-commenter-action#74) [#86](#86) [#82](#82) [#74](#74) [#76](#76) [#78](#78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action fails with API rate limit
2 participants