Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(terraform-docs)!: Add required input for terraform-dir #78

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

chris3ware
Copy link
Member

Finding the terraform directory has been moved to the calling workflow so that a matrix strategy can be defined if multiple terraform directories are found.
The matrix strategy will call this workflow as required.

To achieve this, the find-terraform job has been removed and and a new required input for terraform-dir has been added to the workflow_call event trigger.

Commitlint extension displayed a warning that sign-off was missing
despite sign-off being present. Worked for months, suddenly stopped
working. Not fixing it now. Too much on.
Using a matrix, based on the json output of `find-terraform` within this
workflow failed - the `working-dir` was set to both directories.
`find-terraform` has been moved to the calling workflow and the matrix
strategy has also been defined there.
The scope indicates which folder the README file was updated in.
@chris3ware chris3ware requested a review from a team as a code owner February 14, 2024 11:34
@chris3ware chris3ware merged commit bb05220 into main Feb 14, 2024
@chris3ware chris3ware deleted the feat-multi-dir-terraform-docs branch February 14, 2024 11:37
3ware-release bot pushed a commit that referenced this pull request Feb 14, 2024
## [2.0.0](v1.13.0...v2.0.0) (2024-02-14)

### ⚠ BREAKING CHANGES

* **terraform-docs:** Add required input for `terraform-dir` (#78)

### Enhancement

* **terraform-docs:** Add required input for `terraform-dir` ([#78](#78)) ([bb05220](bb05220))
@3ware-release
Copy link
Contributor

3ware-release bot commented Feb 14, 2024

This PR is included in version 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant