fix(logger): ensure full lock when flushing

pkg/logger/logcounter.go

@@ -2,6 +2,8 @@ package logger
 
 import (
 	"sync"
+
+	"golang.org/x/exp/maps"
 )
 
 type logOrigin struct {
@@ -19,26 +21,34 @@ type logCounter struct {
 func (lc *logCounter) update(lo logOrigin) {
 	lc.rwMutex.Lock()
 	defer lc.rwMutex.Unlock()
+
 	lc.data[lo]++
 }
 
 func (lc *logCounter) Lookup(key logOrigin) (count uint32, found bool) {
 	lc.rwMutex.RLock()
 	defer lc.rwMutex.RUnlock()
+
 	count, found = lc.data[key]
 	return count, found
 }
 
 func (lc *logCounter) dump(flush bool) map[logOrigin]uint32 {
-	lc.rwMutex.RLock()
-	defer lc.rwMutex.RUnlock()
+	if flush {
+		lc.rwMutex.Lock()
+		defer lc.rwMutex.Unlock()
+	} else {
+		lc.rwMutex.RLock()
+		defer lc.rwMutex.RUnlock()
+	}
+
 	dump := make(map[logOrigin]uint32, len(lc.data))
-	for k, v := range lc.data {
-		dump[k] = v
-		if flush {
-			delete(lc.data, k)
-		}
+	maps.Copy(dump, lc.data)
+
+	if flush {
+		maps.Clear(lc.data)
 	}
+
 	return dump
 }