Skip to content

Commit

Permalink
chore(events): decrease SO loader error log level to debug
Browse files Browse the repository at this point in the history
Errors from the SO loader are pretty frequent because of race conditions.
As the user has nothing to do with it, the log level should be lowered from WARN.
  • Loading branch information
AlonZivony committed May 7, 2024
1 parent 5b227f8 commit ae35d67
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
11 changes: 8 additions & 3 deletions pkg/events/derive/symbols_collision.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package derive

import (
"errors"
"github.com/hashicorp/golang-lru/simplelru"
"golang.org/x/exp/maps"

Expand Down Expand Up @@ -182,15 +183,19 @@ func (gen *SymbolsCollisionArgsGenerator) findShObjsCollisions(
// get exported symbols from the shared object BEING loaded
loadingShObj.exportedSymbols, err = gen.soLoader.GetExportedSymbols(loadingShObj.ObjInfo)
if err != nil {
// High level languages like Java might load non-ELF files
// There is no need to log errors for such cases
var notElfErr *sharedobjs.UnsupportedFileError
if errors.As(err, &notElfErr) {
return nil, nil
}
// TODO: rate limit frequent errors for overloaded envs
_, ok := gen.returnedErrorsMap[err.Error()]
if !ok {
gen.returnedErrorsMap[err.Error()] = true
logger.Warnw("symbols_loaded", "object loaded", loadingShObj.ObjInfo, "error", err.Error())
} else {
logger.Debugw("symbols_loaded", "object loaded", loadingShObj.ObjInfo, "error", err.Error())
}
return nil, errfmt.WrapError(err)
return nil, nil
}
loadingShObj.FilterSymbols(gen.symbolsBlacklistMap) // del symbols NOT in blacklist
loadingShObj.FilterOutSymbols(gen.symbolsWhitelistMap) // del symbols IN the white list
Expand Down
2 changes: 0 additions & 2 deletions pkg/events/derive/symbols_loaded.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ func (symbsLoadedGen *symbolsLoadedEventGenerator) deriveArgs(
_, ok := symbsLoadedGen.returnedErrors[err.Error()]
if !ok {
symbsLoadedGen.returnedErrors[err.Error()] = true
logger.Warnw("symbols_loaded", "object loaded", loadingObjectInfo, "error", err.Error())
} else {
logger.Debugw("symbols_loaded", "object loaded", loadingObjectInfo, "error", err.Error())
}
return nil, nil
Expand Down

0 comments on commit ae35d67

Please sign in to comment.