chore(tests): test packet direction in net e2e

In HTTP e2e test, add a packet direction test.

signatures/helpers/helpers.go

@@ -163,6 +163,25 @@ func GetPathFromRawAddr(addr map[string]string) (string, error) {
 // Network Protocol Event Types
 //
 
+// GetPacketMetadata converts json to PacketMetadata
+func GetPacketMetadata(
+	event trace.Event,
+	argName string) (
+	trace.PacketMetadata,
+	error) {
+	arg, err := GetTraceeArgumentByName(event, argName, GetArgOps{DefaultArgs: false})
+	if err != nil {
+		return trace.PacketMetadata{}, err
+	}
+
+	argPacketMetadata, ok := arg.Value.(trace.PacketMetadata)
+	if ok {
+		return argPacketMetadata, nil
+	}
+
+	return trace.PacketMetadata{}, fmt.Errorf("packet metadata: type error (should be trace.PacketMetadata, is %T)", arg.Value)
+}
+
 // GetProtoIPv4ByName converts json to ProtoIPv4
 func GetProtoIPv4ByName(
 	event trace.Event,
@@ -198,7 +217,7 @@ func GetProtoIPv4ByName(
 		return argProtoIPv4, nil
 	}
 
-	return trace.ProtoIPv4{}, fmt.Errorf("protocol IPv4: type error")
+	return trace.ProtoIPv4{}, fmt.Errorf("protocol IPv4: type error (should be trace.ProtoIPv4, is %T)", arg.Value)
 }
 
 // GetProtoIPv6ByName converts json to ProtoIPv6
@@ -231,7 +250,7 @@ func GetProtoIPv6ByName(
 		return argProtoIPv6, nil
 	}
 
-	return trace.ProtoIPv6{}, fmt.Errorf("protocol IPv6: type error")
+	return trace.ProtoIPv6{}, fmt.Errorf("protocol IPv6: type error (should be trace.ProtoIPv6, is %T)", arg.Value)
 }
 
 // GetProtoUDPByName converts json to ProtoUDP
@@ -258,7 +277,7 @@ func GetProtoUDPByName(
 		return argProtoUDP, nil
 	}
 
-	return trace.ProtoUDP{}, fmt.Errorf("protocol UDP: type error")
+	return trace.ProtoUDP{}, fmt.Errorf("protocol UDP: type error (should be trace.ProtoUDP, is %T)", arg.Value)
 }
 
 // GetProtoTCPByName converts json to ProtoTCP
@@ -298,7 +317,7 @@ func GetProtoTCPByName(
 		return argProtoTCP, nil
 	}
 
-	return trace.ProtoTCP{}, fmt.Errorf("protocol TCP: type error")
+	return trace.ProtoTCP{}, fmt.Errorf("protocol TCP: type error (should be trace.ProtoTCP, is %T)", arg.Value)
 }
 
 // GetProtoICMPByName converts json to ProtoICMP
@@ -325,7 +344,7 @@ func GetProtoICMPByName(
 		return argProtoICMP, nil
 	}
 
-	return trace.ProtoICMP{}, fmt.Errorf("protocol ICMP: type error")
+	return trace.ProtoICMP{}, fmt.Errorf("protocol ICMP: type error (should be trace.ProtoICMP, is %T)", arg.Value)
 }
 
 // GetProtoICMPv6ByName converts json to ProtoICMPv6
@@ -352,7 +371,7 @@ func GetProtoICMPv6ByName(
 		return argProtoICMPv6, nil
 	}
 
-	return trace.ProtoICMPv6{}, fmt.Errorf("protocol ICMPv6: type error")
+	return trace.ProtoICMPv6{}, fmt.Errorf("protocol ICMPv6: type error (should be trace.ProtoICMPv6, is %T)", arg.Value)
 }
 
 // GetProtoDNSByName converts json to ProtoDNS
@@ -395,7 +414,7 @@ func GetProtoDNSByName(
 		return argProtoDNS, nil
 	}
 
-	return trace.ProtoDNS{}, fmt.Errorf("protocol DNS: type error")
+	return trace.ProtoDNS{}, fmt.Errorf("protocol DNS: type error (should be trace.ProtoDNS, is %T)", arg.Value)
 }
 
 func GetProtoHTTPByName(
@@ -414,5 +433,5 @@ func GetProtoHTTPByName(
 		return argProtoHTTP, nil
 	}
 
-	return trace.ProtoHTTP{}, fmt.Errorf("protocol HTTP: type error")
+	return trace.ProtoHTTP{}, fmt.Errorf("protocol HTTP: type error (should be trace.ProtoHTTP, is %T)", arg.Value)
 }

tests/e2e-net-signatures/e2e-http.go

@@ -48,6 +48,10 @@ func (sig *e2eHTTP) OnEvent(event protocol.Event) error {
 		return fmt.Errorf("failed to cast event's payload")
 	}
 
+	if eventObj.ProcessName != "curl" {
+		return nil
+	}
+
 	if eventObj.EventName == "net_packet_http" {
 		http, err := helpers.GetProtoHTTPByName(eventObj, "proto_http")
 		if err != nil {
@@ -58,6 +62,15 @@ func (sig *e2eHTTP) OnEvent(event protocol.Event) error {
 			return nil
 		}
 
+		md, err := helpers.GetPacketMetadata(eventObj, "metadata")
+		if err != nil {
+			return err
+		}
+
+		if !testHttpDirectionAndPacketDirection(&md, &http) {
+			return nil
+		}
+
 		if !strings.HasPrefix(http.Protocol, "HTTP/") {
 			return nil
 		}
@@ -78,3 +91,10 @@ func (sig *e2eHTTP) OnSignal(s detect.Signal) error {
 }
 
 func (sig *e2eHTTP) Close() {}
+
+func testHttpDirectionAndPacketDirection(md *trace.PacketMetadata, http *trace.ProtoHTTP) bool {
+	// This test is done in the context of a curl request, but if it was in the context
+	// of a server then the direction of the packet would be opposite to the http direction
+	return (http.Direction == "request" && md.Direction == trace.PacketEgress) ||
+		(http.Direction == "response" && md.Direction == trace.PacketIngress)
+}