Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet direction flag #3701

Closed
NDStrahilevitz opened this issue Nov 20, 2023 · 0 comments · Fixed by #3706
Closed

Add packet direction flag #3701

NDStrahilevitz opened this issue Nov 20, 2023 · 0 comments · Fixed by #3706

Comments

@NDStrahilevitz
Copy link
Collaborator

In order to implement #3697 on top of TCP packet, and since it's useful information in general, the ingress/egress direction of packets should be added to the net_packet family of events.

This can be added either as an argument to all these events, or it should be added to a new Network context section.
If it's decided that a section should be added instead, it's likely more "correct" to move the following arguments there as well: src, dst, src_port, src_dst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant