Packet direction flag #3706
Merged
Packet direction flag #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDStrahilevitz
commented
Nov 22, 2023
NDStrahilevitz
force-pushed
the
packet_direction_flag
branch
2 times, most recently
from
ee2c21f
to
30df4cb
Compare
NDStrahilevitz
force-pushed
the
packet_direction_flag
branch
3 times, most recently
from
b3ae85f
to
fb990be
Compare
rafaeldtinoco
approved these changes
Nov 23, 2023
Bump types to commit 9a6b89e for trace.PacketMetadata
Reduce duplication in most packet derivations by moving payload validation and extraction to its own helper.
Add new `metadata` argument to all packet events. This metadata struct duplicates the previous src and dst and port arguments to a single struct, with the addition of including a new `direction` field. This direction is an enum describing if the packet was ingress(1) or egress(2).
In HTTP e2e test, add a packet direction test.
NDStrahilevitz
force-pushed
the
packet_direction_flag
branch
from
fb990be
to
d3c1b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
d3c1b3d chore(tests): test packet direction in net e2e
13dff15 docs(network): mention new metadata argument
5345cf9 feature(network): add packet metadata argument
18b4663 refactor(network): parse payload in helper
d8c8d1b chore(go.mod): bump types
2. Explain how to test it
A test was added in the HTTP e2e test.
In addition, one can see for themselves by running any of the changed net packet events (for example
net_packet_icmpand looking at the newmetadataargument.3. Other comments
Resolve #3701