Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stat syscalls are missing #12

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Conversation

yanivagman
Copy link
Collaborator

No description provided.

@@ -833,6 +833,8 @@ def print_event(self, cpu, data, size):

args = list()

eventfunc = "dummy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As eventfunc is set only for the events that have a different function name than the event name (e.g. lstat), and not for all the other events, it is initialized to this value here in order to emphasis the fact that it shouldn't be found in events_to_trace later on for events which were not chosen by the user (line 1065 in this commit)

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo the question I have.

@yanivagman yanivagman merged commit 0630258 into master Nov 21, 2019
@yanivagman yanivagman deleted the fix_missing_stat_syscalls branch December 16, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants