Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface more errors and validate the newly created symbols map #1882

Merged
merged 1 commit into from Jun 29, 2022
Merged

Surface more errors and validate the newly created symbols map #1882

merged 1 commit into from Jun 29, 2022

Conversation

grantseltzer
Copy link
Contributor

Signed-off-by: grantseltzer grantseltzer@gmail.com

Initial Checklist

  • There is an issue describing the need for this PR.
  • Git log contains summary of the change.

Description (git log)

commit 04efaaa (HEAD -> fix-panic-finit-module-event, pfork/fix-panic-finit-module-event)
Author: grantseltzer grantseltzer@gmail.com
Date: Tue Jun 28 10:29:16 2022 -0400

Surface more errors and validate the newly created symbols map

Signed-off-by: grantseltzer <grantseltzer@gmail.com>

Fixes: #1843

Type of change

  • Bug fix (non-breaking change fixing an issue, preferable).

How Has This Been Tested?

sudo ./dist/tracee-ebpf -t e=finit_module and loading a kmod

Final Checklist:

Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.

  • I have made corresponding changes to the documentation.
  • My code follows the style guidelines (C and Go) of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have added tests that prove my fix, or feature, is effective.
  • New and existing unit tests pass locally with my changes.

Git Log Checklist:

My commits logs have:

  • Subject starts with "subsystem|file: description".
  • Do not end the subject line with a period.
  • Limit the subject line to 50 characters.
  • Separate subject from body with a blank line.
  • Use the imperative mood in the subject line.
  • Wrap the body at 72 characters.
  • Use the body to explain what and why instead of how.

@grantseltzer
Copy link
Contributor Author

@AsafEitani The real fix is on line 1295, the kernel symbol map that was just created should be validated, not the old one.

@AsafEitani
Copy link
Contributor

LGTM

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
@grantseltzer grantseltzer merged commit da7044e into aquasecurity:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tracee crash on kernel module load error
3 participants