chore: migrate to golang-lru v2 #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaeldtinoco assigned you so you can commit pcap tests on top. |
|
@NDStrahilevitz Im sorry for the burden Nadav, could you rebase this? I promise to test and merge it right as you do. Thanks! |
Upgrade includes generics support and optimizations.
NDStrahilevitz
force-pushed
the
chore/golang-lru-v2-upgrade
branch
from
6693d48
to
28cc6a2
Compare
|
@rafaeldtinoco Done :) |
|
Seems to be working fine:
|
NDStrahilevitz
added a commit
to NDStrahilevitz/tracee
that referenced
this pull request
Jun 14, 2023
Accidentally added in aquasecurity#3140.
NDStrahilevitz
added a commit
that referenced
this pull request
Jun 14, 2023
Accidentally added in #3140.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
hashicorp/golang-lruto v2.This includes generics and further optimizations and fixes.
TODO: add pcaps tests to make sure it doesn't break.