-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: add check-pr rule #3215
Conversation
Hum, its best if we change "resume" (meaning returning from interruption) to something that describes "summary". make pr-summary ? Or something simpler, if you prefer. |
Also, please keep the Author format as "Name email@domain" please. Anything git related usually use that as a reference to authors. Other than that, I like the summary idea, we have to advertise in the github template as well . |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ACTUALLY... thinking straight now.. WDYT about removing the ========== ? I know you fixed a 80 cols to the "====" line, but sometimes terminals aren't fully 80 cols, and it brakes terminal output. I'd rather have **** SOMETHING **** or something else, but not a header that obligates to have a specific number of columns in the terminal, WDYT ? |
This rule will run all code checks (not tests) and output a formatted summary of all commits that are not yet in the main branch to be used for pull requests head comments.
Yep, thanks for the change/fix. |
1. Explain what the PR does
9021720 makefile: add check-pr rule (2023/jun/07) Geyslan Gregório <geyslan@gmail.com>
2. Explain how to test it
From your working branch, after commits created, run
make check-pr
.3. Other comments
Chore.