Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: clean up/fix provisioning script #3216

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jun 7, 2023

1. Explain what the PR does

bed3862 vagrant: clean up/fix provisioning script (2023/jun/07) Geyslan Gregório <geyslan@gmail.com>

The commit includes some changes to the provisioning script:
- Added the 'vb.cpus = 4'.
- Added the 'export DEBIAN_FRONTEND=noninteractive' line to silence
  warnings.
- Formatted string expansion in some commands.
- Removed unnecessary 'sudo' commands.
- Fixed the 'kubectl' installation process.
  It was previously using a deprecated path. Now it uses the
  official one.
- Fixed Go's binary path to the 'PATH' environment variable in the
  Vagrant user's '.profile'.
  It was previously not being expanded by using single quotes.
- Added Go's binary path to the 'PATH' environment variable in the
  root user's '.bashrc'.
- Modified the '/etc/sudoers.d/vagrant' file to include 'secure_path'
  variable with Go's binary path.

These changes enhance the development environment for the Vagrant box
and fix some issues that were present in the previous version.

2. Explain how to test it

vagrant destroy (backup your local changes as you wish)
vagrant up
vagrant ssh
make all
make test-unit
make test-integration

3. Other comments

@geyslan geyslan added this to the v0.16.0 milestone Jun 7, 2023
@geyslan geyslan self-assigned this Jun 7, 2023
@geyslan geyslan removed this from the v0.16.0 milestone Jun 7, 2023
The commit includes some changes to the provisioning script:
- Added the 'vb.cpus = 4'.
- Added the 'export DEBIAN_FRONTEND=noninteractive' line to silence
  warnings.
- Formatted string expansion in some commands.
- Removed unnecessary 'sudo' commands.
- Fixed the 'kubectl' installation process.
  It was previously using a deprecated path. Now it uses the
  official one.
- Fixed Go's binary path to the 'PATH' environment variable in the
  Vagrant user's '.profile'.
  It was previously not being expanded by using single quotes.
- Added Go's binary path to the 'PATH' environment variable in the
  root user's '.bashrc'.
- Modified the '/etc/sudoers.d/vagrant' file to include 'secure_path'
  variable with Go's binary path.

These changes enhance the development environment for the Vagrant box
and fix some issues that were present in the previous version.
@rafaeldtinoco
Copy link
Contributor

LGTM

Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit b4bb239 into aquasecurity:main Jun 9, 2023
2 checks passed
@geyslan geyslan deleted the vagrant-chore branch July 31, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants