flags: refactor FilterMap #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivagman
force-pushed
the
refactor_filter_map
branch
from
09f8634
to
9b68e72
Compare
Currently the filterFlag struct includes information about the policy - it's index and name. Since FilterMap is already indexed by policy, this information is redundant and can be set once per policy. Removing the policy information from filterFlag makes code simpler and easier to modify in future PR (e.g. splitting filter flag to event and scope flags).
yanivagman
force-pushed
the
refactor_filter_map
branch
from
9b68e72
to
fa0eda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Currently the filterFlag struct includes information about the policy - it's index and name. Since FilterMap is already indexed by policy, this information is redundant and can be set once per policy. Removing the policy information from filterFlag makes code simpler and easier to modify in future PR (e.g. splitting filter flag to event and scope flags).
2. Explain how to test it
3. Other comments