Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: set LIBBPFGO_OSRELEASE_FILE default value #3226

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jun 12, 2023

1. Explain what the PR does

Fix: #3156

272672e make: set LIBBPFGO_OSRELEASE_FILE default value (2023/jun/12) <Geyslan Gregório>

This sets LIBBPFGO_OSRELEASE_FILE to "/etc/os-release-host" by default
if it is not set, so that the docker command can be run without
specifying the file.

It also updates the documentation to reflect this change.

2. Explain how to test it

make -f builder/Makefile.tracee-container build-tracee
make -f builder/Makefile.tracee-container run-tracee

3. Other comments

This sets LIBBPFGO_OSRELEASE_FILE to "/etc/os-release-host" by default
if it is not set, so that the docker command can be run without
specifying the file.

It also updates the documentation to reflect this change.
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 2d124dd into aquasecurity:main Jun 14, 2023
26 checks passed
@geyslan geyslan deleted the 3156-docker-cmd branch July 31, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify docker run command
3 participants