-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: extract config structs to its own pkg #3228
Conversation
25d9e2b
to
c5bc5ca
Compare
c5bc5ca
to
dd37642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geyslan why didn't we also bring the engine.Config, since all configs will be under pkg/config
why not the engine as well?
I think it makes sense. Besides engine we have also pcaps. |
Bringing the engine configuration into pkg/config made the tracee-rules now dependent on pkg/config. So this build change is required: For signatures as well. So, @rafaeldtinoco and @NDStrahilevitz, is there some impact of depending (in the build process) on the libbpf in signatures and tracee-rules - due to that type relocation (Config). |
13c9345
to
103cf01
Compare
@josedonizetti I'm going to drop that engine config relocation commit. Currently, it would create dependencies not really needed. We'll come back to that when we get rid of the rules bin. |
103cf01
to
b685cc5
Compare
This extracts the config file from the ebpf package to its own. It also moves into the config package PrinterConfig and flags/OutputConfig renaming the latter to PrinterOutputConfig.
It names the struct `PcapsConfig` and moves it to pkg/config.
b685cc5
to
1f91b80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on not making tracee-rules depending on libbpf just now (add a TODO for when we have the single binary if some other change is needed). LGTM
1. Explain what the PR does
Fix: #3031
1f91b80 config: move pcaps Config struct to pkg/config (2023/jun/13) Geyslan Gregório <geyslan@gmail.com>
ec36fe9 flags: rename OutputConfig to PrepareOutputResult (2023/jun/13) Geyslan Gregório <geyslan@gmail.com>
0cb1395 config: extract config structs to its own pkg (2023/jun/13) Geyslan Gregório <geyslan@gmail.com>
2. Explain how to test it
3. Other comments