policies: rename list fields to be plural #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
refactor-policies
branch
2 times, most recently
from
ab3909b
to
f333fdb
Compare
josedonizetti
force-pushed
the
refactor-policies
branch
from
f333fdb
to
7a003a1
Compare
yanivagman
reviewed
Jun 22, 2023
josedonizetti
force-pushed
the
refactor-policies
branch
3 times, most recently
from
4c8eec6
to
d2a1034
Compare
|
Still a draft? |
josedonizetti
force-pushed
the
refactor-policies
branch
from
d2a1034
to
16b3c87
Compare
josedonizetti
force-pushed
the
refactor-policies
branch
from
16b3c87
to
d5b05d9
Compare
rafaeldtinoco
pushed a commit
to rafaeldtinoco/tracee
that referenced
this pull request
Jun 29, 2023
Conflicts:
pkg/policy/policy_file_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fix #3241
Fix #3181
2. Explain how to test it
This PR does two things:
1 - renames a few fields of the policy, and fix the code where appropriate.
filter -> filters
action -> actions
2 - add support to multiple default actions
defaultAction -> defaultActions
3. Other comments
This PR will break the internal tests, because of the policies change.