Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracee: skip golang plugin for static binaries #3244

Conversation

josedonizetti
Copy link
Collaborator

1. Explain what the PR does

Fix #2778

If the binary is static, we will skip the golang signatures in order to avoid panics, so tracee-static can still be used for builtin events and rego signatures.

2. Explain how to test it

on main:

make clean && make
rm dist/tracee
BTFHUB=0 STATIC=1 make tracee

sudo ./dist/tracee # should trigger the error

on this PR, the same test print it is skipping the golang plugin.

3. Other comments

@josedonizetti
Copy link
Collaborator Author

Thanks for the tip on checking the symbols @rafaeldtinoco :D

@josedonizetti josedonizetti force-pushed the skip-golang-signatures-for-static-binary branch from 332dc39 to 3b908dd Compare June 14, 2023 23:38
@josedonizetti josedonizetti force-pushed the skip-golang-signatures-for-static-binary branch from 3b908dd to 61ee247 Compare June 14, 2023 23:41
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll ask for @yanivagman input on this one as it was a direct request from him (I'm in doubt about the Warn versus Debug, it's just a question of usability).

@rafaeldtinoco rafaeldtinoco merged commit 75a962f into aquasecurity:main Jun 22, 2023
25 checks passed
@josedonizetti josedonizetti deleted the skip-golang-signatures-for-static-binary branch June 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracee can't load signature produced binary artifact tar.gz
2 participants