fix: fix container edge case in events pipeline #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue where an empty container ID was observed while the containerStarted flag was set to true. Since it is not possible to have knowledge of a started container without its ID, this behavior is considered an edge case, potentially caused by a race condition. The fix involves modifying the decode stage to set the containerStarted flag to false whenever an empty container ID is found. This ensures that the flag accurately reflects the event's container status and resolves the inconsistency observed in the issue aquasecurity#3251.
geyslan
force-pushed
the
3251-container-cgroup
branch
from
045f08b
to
3ddc2a2
Compare
NDStrahilevitz
pushed a commit
to NDStrahilevitz/tracee
that referenced
this pull request
Jul 3, 2023
This commit addresses an issue where an empty container ID was observed while the containerStarted flag was set to true. Since it is not possible to have knowledge of a started container without its ID, this behavior is considered an edge case, potentially caused by a race condition. The fix involves modifying the decode stage to set the containerStarted flag to false whenever an empty container ID is found. This ensures that the flag accurately reflects the event's container status and resolves the inconsistency observed in the issue aquasecurity#3251.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fix: #3251
3ddc2a2 fix: Fix containerStarted flag in decode stage (2023/jun/19) Geyslan Gregório <geyslan@gmail.com>
2. Explain how to test it
3. Other comments