Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: hidden_kernel_module changes #3255

Merged
merged 1 commit into from Jun 26, 2023

Conversation

OriGlassman
Copy link
Collaborator

1. Explain what the PR does

  • Do not use GetSymbolByName (as it's not crucial and seem to have a strong impact on performance)
  • Fix capability issue in getting the addresses from /proc/modules
  • Cosmetics

2. Explain how to test it

./tracee -f e=hidden_kernel_module

Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, I just don't understand the use of the unmaintained errors package

pkg/events/derive/hidden_kernel_module.go Outdated Show resolved Hide resolved
- Do not use GetSymbolByName (as it's not crucial and seem to have a
  strong impact on performance)
- Fix capability issue in getting the addresses from /proc/modules
- Cosmetics
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanivagman yanivagman merged commit f1cb547 into aquasecurity:main Jun 26, 2023
25 checks passed
rafaeldtinoco pushed a commit to rafaeldtinoco/tracee that referenced this pull request Jun 29, 2023
- Do not use GetSymbolByName (as it's not crucial and seem to have a
  strong impact on performance)
- Fix capability issue in getting the addresses from /proc/modules
- Cosmetics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants