New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move syscaller to dist #3269
Conversation
@geyslan I noticed that I can't vscode "run all tests" because of integration root needs. Is there a way we can "bypass" tests if not root, instead of failing ? This way I can use that feature in vscode (and we still can test integration using root in other places). WDYT ? |
Let me give a try. Back soon. |
Doable. Changing the behaviour.
|
a0580dc
to
6aa2295
Compare
This commit moves syscaller to dist. This also makes integration tests don't fail if not run as root. Now, they will just skip the tests that require root privileges.
6aa2295
to
dc06833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit moves syscaller to dist. This also makes integration tests don't fail if not run as root. Now, they will just skip the tests that require root privileges.
1. Explain what the PR does
dc06833 chore: move syscaller to dist (2023/jun/26) Geyslan Gregório <geyslan@gmail.com>
2. Explain how to test it
make integration-test
sudo make integration-test
3. Other comments