Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: update syscall_pathname for security_file_open #3298

Merged
merged 1 commit into from Jul 11, 2023

Conversation

OriGlassman
Copy link
Collaborator

1. Explain what the PR does

syscall_pathname was fetched only for open(at) syscalls, thus was empty for security_file_open originated from execve(at) syscall

2. Explain how to test it

./tracee -f e=security_file_open

syscall_pathname was fetched only for open(at) syscalls, thus was empty for security_file_open originated from
execve(at) syscall
@NDStrahilevitz
Copy link
Collaborator

NDStrahilevitz commented Jul 4, 2023

Test case doesn't include a reproducer for execve and execveat. Would you mind adding such a reproducer (and potentially an instrumentation test?)

Edit: Resolved offline as out of scope for the author.

Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 48c2d97 into aquasecurity:main Jul 11, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants