fix: validate policy names are rfc 1123 #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
policy-names-rfc1123
branch
2 times, most recently
from
77414e2
to
030c0f7
Compare
josedonizetti
force-pushed
the
policy-names-rfc1123
branch
from
030c0f7
to
118899a
Compare
|
@josedonizetti is this ready for review? |
|
@geyslan yes |
geyslan
changed the title
geyslan
pushed a commit
to geyslan/tracee
that referenced
this pull request
Jul 27, 2023
commit: 933301c (main), cherry-pick
geyslan
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fix #3333
Policy names must be k8s compatible, which means defined as RFC 1123.
So the name must:
contain no more than 63 characters
contain only lowercase alphanumeric characters, '-' or '.'
start with an alphanumeric character
end with an alphanumeric character
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
2. Explain how to test it
3. Other comments