Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ebpf): size of mntns/pidns filters key holders #3337

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jul 25, 2023

Close: #3327

1. Explain what the PR does

bb8c4c8 fix(ebpf): size of mntns/pidns filters key holders (2023/jul/25) Geyslan Gregório <geyslan@gmail.com>

Even though the namespace id is a 32-bit integer, the key size for the
mntns/pidns filters has been set to 64-bit. This caused these filters to
not work correctly as their key value was being read beyond limits.

Chore: Add integration tests for mntns/pidns filters.

2. Explain how to test it

See #3327.

3. Other comments

Even though the namespace id is a 32-bit integer, the key size for the
mntns/pidns filters has been set to 64-bit. This caused these filters to
not work correctly as their key value was being read beyond limits.

Chore: Add integration tests for mntns/pidns filters.
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 68e9609 into aquasecurity:main Jul 25, 2023
27 checks passed
geyslan added a commit to geyslan/tracee that referenced this pull request Jul 25, 2023
Even though the namespace id is a 32-bit integer, the key size for the
mntns/pidns filters has been set to 64-bit. This caused these filters to
not work correctly as their key value was being read beyond limits.

Chore: Add integration tests for mntns/pidns filters.

commit: bb8c4c8 (main), cherry-pick
geyslan added a commit that referenced this pull request Jul 25, 2023
Even though the namespace id is a 32-bit integer, the key size for the
mntns/pidns filters has been set to 64-bit. This caused these filters to
not work correctly as their key value was being read beyond limits.

Chore: Add integration tests for mntns/pidns filters.

commit: bb8c4c8 (main), cherry-pick
@geyslan geyslan deleted the 3327-fix-key-size branch July 31, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not equal mntns and pidns are not respected
2 participants