Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): change check-pr output format #3351

Merged
merged 1 commit into from Jul 31, 2023
Merged

chore(build): change check-pr output format #3351

merged 1 commit into from Jul 31, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jul 31, 2023 •
edited

1. Explain what the PR does

4ef7356 chore(build): change check-pr output format

2. Explain how to test it

3. Other comments

@geyslan geyslan self-assigned this Jul 31, 2023
@geyslan
Copy link
Member Author

geyslan commented Jul 31, 2023

For a body-less single commit.

image

@geyslan
Copy link
Member Author

geyslan commented Jul 31, 2023 •
edited

I'm not liking how it's outputting for body-less commits. I'll try other approach soon.

rafaeldtinoco
rafaeldtinoco approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member Author

geyslan commented Jul 31, 2023 •
edited

Now, if the commit doesn't have body it's not outputted again in the full list.

I think it is better:

image

@geyslan geyslan merged commit 518469d into aquasecurity:main Jul 31, 2023
2 checks passed
@geyslan geyslan deleted the check-pr-format branch July 31, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

Assignees

@geyslan geyslan

Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geyslan @rafaeldtinoco