Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filter): remove unneeded workaround #3352

Merged
merged 1 commit into from Aug 1, 2023
Merged

fix(filter): remove unneeded workaround #3352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 0 additions & 28 deletions pkg/cmd/flags/filter.go
View file
Open in desktop
Expand Up @@ -3,10 +3,7 @@ package flags
import (
"strings"

"github.com/aquasecurity/libbpfgo/helpers"

"github.com/aquasecurity/tracee/pkg/events"
"github.com/aquasecurity/tracee/pkg/logger"
)

func filterHelp() string {
Expand Down Expand Up @@ -113,31 +110,6 @@ func prepareEventsToTrace(eventFilter eventFilter, eventsNameToID map[string]eve
}
}

// Exclude network events from the default set if kernel v4.19.
// Issue: https://github.com/aquasecurity/tracee/issues/1602
// TODO: workaround until we have the feature probing mechanism
if osInfo, err := helpers.GetOSInfo(); err == nil {
kernel51ComparedToRunningKernel, err := osInfo.CompareOSBaseKernelRelease("5.1.0")
if err != nil {
logger.Errorw("Failed to compare kernel version", "error", err)
} else {
if kernel51ComparedToRunningKernel == helpers.KernelVersionNewer {
id_like := osInfo.GetOSReleaseFieldValue(helpers.OS_ID_LIKE)
if !strings.Contains(id_like, "rhel") {
// disable network events for v4.19 kernels other than RHEL based ones
logger.Debugw("Kernel <= v5.1, disabling network events from default set")
for _, id := range setsToEvents["default"] {
if id >= events.NetPacketIPv4 && id <= events.MaxUserNetID {
isExcluded[id] = true
}
}
}
}
}
} else {
logger.Errorw("Failed to get OS info", "error", err)
}

// mark excluded events (isExcluded) by their id
for _, name := range excludeEvents {
if strings.HasSuffix(name, "*") { // handle event prefixes with wildcards
Expand Down