feat: filter file capture by ELF type #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonZivony
added
kind/feature
area/capture
milestone/v0.18.0
and removed
kind/documentation
area/UX
area/flags
labels
AlonZivony
force-pushed
the
feature/elf-capture-filter
branch
from
2b14f7f
to
bda9ec7
Compare
github-actions
bot
added
kind/documentation
area/UX
area/flags
and removed
area/capture
labels
AlonZivony
force-pushed
the
feature/elf-capture-filter
branch
6 times, most recently
from
01a5a31
to
ce9375b
Compare
yanivagman
reviewed
Aug 20, 2023
| file_id.ctime = 0; | ||
| if (start_pos == 0) { | ||
| // Check if header is matching ELF header | ||
| u8 header[FILE_MAGIC_HDR_SIZE] = {}; |
There was a problem hiding this comment.
Shouldn't this array be initialized to 0?
This can be important if header size is less than FILE_MAGIC_HDR_SIZE
There was a problem hiding this comment.
So using the syntax of x = {} should initialized the value to zero as far as I know.
I have checked it once with @roikol and it worked.
Add a filter for file IO capture filtering ELF files. ELF files are the most important files to capture in security research, so filtering according to ELF files is very effective to reduce noise.
AlonZivony
force-pushed
the
feature/elf-capture-filter
branch
from
ce9375b
to
20635b9
Compare
AlonZivony
added a commit
to AlonZivony/tracee
that referenced
this pull request
Sep 3, 2023
This reverts commit fd47dfb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Add a filter for file IO capture filtering ELF files. ELF files are the most important files to capture in security research, so filtering according to ELF files is very effective to reduce noise.
fix #3359